[Blazor] prevent infinite loop in SKCanvasView - #1889
Merged
Conversation
JensKrumsieck
changed the title
mattleibow
reviewed
Dec 14, 2021
mattleibow
left a comment
mattleibow
left a comment
Contributor
There was a problem hiding this comment.
This makes sense. Just wondering if we should just be casting to int instead of rounding? That is what is happening on line 80.
Not sure if that was causing an issue and you already tried that. Feels like it should work.
Contributor
Author
|
You are right. I looked back at the console output from #1838 (comment) It cuts the digits after the comma instead of rounding. |
mattleibow
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Prevents infinite resize loop - i don't know if this is the most elegant solution, but it works.
Added the following line to
OnSizeChangedEvent of BlazorSKCanvasViewIf Monitor scaling is applied in Windows Settings App, the view keeps multiplying the canvas size with the DPI (in my case being 1.25 for 125% scaling) in the
Invalidate-Method.The Canvas will be resized to the new size which results in the
SizeWatcherInteropto fire itsOnSizeChangedEvent which will setcanvasSizetonewSizeand callsInvalidateagain to start infinite loop, also mentioned here:#1838 (comment)
Bugs Fixed
#1838
API Changes
None
Behavioral Changes
None
PR Checklist